openclaw - 💡(How to fix) Fix [voice-call] maxS2SRuntimeMs: limit cumulative S2S active time, not wall-clock call duration [1 comments, 1 participants]

Fix Plan

To implement the new maxS2SRuntimeMs config field and track cumulative S2S open time, follow these steps:

• Update the OpenAIRealtimeS2SSession class:
  • Add a startTimer method to track the cumulative S2S open time when connect() is called.
  • Add a stopAndAccumulate method to pause the timer when close() or pauseForHold() is called.
  • Implement the getTotalS2SRuntimeMs() method to return the total S2S runtime.
• Update the webhook.ts file:
  • Check the S2S runtime after each resumeFromHold() call.
  • End the call gracefully if the maxS2SRuntimeMs limit is exceeded.

Example Code

// OpenAIRealtimeS2SSession class
private s2sRuntimeMs: number = 0;
private timer: NodeJS.Timeout;

connect(): void {
  this.timer = setInterval(() => {
    this.s2sRuntimeMs += 1000; // increment by 1 second
  }, 1000);
}

close(): void {
  clearInterval(this.timer);
}

pauseForHold(): void {
  clearInterval(this.timer);
}

resumeFromHold(): void {
  this.timer = setInterval(() => {
    this.s2sRuntimeMs += 1000; // increment by 1 second
  }, 1000);
}

getTotalS2SRuntimeMs(): number {
  return this.s2sRuntimeMs;
}

// webhook.ts
const maxS2SRuntimeMs = 600000; // 10 minutes

resumeFromHold(): void {
  const s2sSession = new OpenAIRealtimeS2SSession();
  const totalS2SRuntimeMs = s2sSession.getTotalS2SRuntimeMs();
  if (totalS2SRuntimeMs > maxS2SRuntimeMs) {
    // end call gracefully
    console.log('Max S2S runtime exceeded. Ending call.');
    // add call termination logic here
  }
}

Verification

To verify the fix, test the following scenarios:

• A call that exceeds the maxS2SRuntimeMs limit should end gracefully.
• A call that is put on hold and then resumed should not increment the S2S runtime while on hold.
• A call that is terminated due to exceeding the maxS2SRuntimeMs limit should log a message indicating the reason for termination.