PR #1: fix(app-server): clear_path treats absent intermediate tables as a no-op

• Repository: sumaiazaman/codex
• Author: sumaiazaman
• State: open | merged: False
• Link: https://github.com/sumaiazaman/codex/pull/1

Description (problem / solution / changelog)

Summary

Fixes openai/codex#20145.

config/value/write with value: null is the API contract for clearing/unsetting a config key. When the path points to a nested key whose parent table does not yet exist in config.toml (e.g. clearing features.personality from an empty file), clear_path was returning MergeError::PathNotFound which surfaces to callers as configPathNotFound / Path not found.

The correct behaviour is to treat it as an idempotent no-op — the value is already absent, so the clear succeeds with no file change.

Root cause — two arms in clear_path that encounter a missing intermediate table:

// before
TomlValue::Table(table) => {
    current = table.get_mut(segment).ok_or(MergeError::PathNotFound)?;
}
_ => return Err(MergeError::PathNotFound),

Fix — return Ok(false) (value unchanged) instead of propagating an error:

// after
TomlValue::Table(table) => match table.get_mut(segment) {
    Some(next) => current = next,
    None => return Ok(false),
},
_ => return Ok(false),

The as_table_mut() guard at the end of the function is updated consistently for the same reason.

Changes

• codex-rs/app-server/src/config_manager_service.rs — fix clear_path
• codex-rs/app-server/src/config_manager_service_tests.rs — regression test clear_missing_nested_config_is_noop

Test plan

• New test clear_missing_nested_config_is_noop reproduces the reported failure before the fix and passes after
• Existing write_value_* tests continue to pass
• cargo test -p codex-app-server green

Changed files

• codex-rs/app-server/src/config_manager_service.rs (modified, +6/-5)
• codex-rs/app-server/src/config_manager_service_tests.rs (modified, +26/-0)

PR #20334: Make missing config clears no-ops

• Repository: openai/codex
• Author: etraut-openai
• State: open | merged: False
• Link: https://github.com/openai/codex/pull/20334

Description (problem / solution / changelog)

Why

Fixes #20145.

config/value/write treats a JSON null value as a request to clear the config key. Clearing a key that is already absent should be idempotent, but clearing a nested key such as features.personality from an empty config.toml returned configPathNotFound because clear_path treated the missing features parent table as an error.

That makes app-server reset flows brittle because clients have to read first and avoid sending a clear request unless the parent path already exists.

What Changed

• Updated app-server config clearing so missing intermediate tables, or non-table parents, are treated as an unchanged no-op.
• Removed the now-unreachable MergeError::PathNotFound path from config write merging.
• Added a regression test covering features.personality = null against an empty user config.

Verification

• cargo test -p codex-app-server clear_missing_nested_config_is_noop
• cargo test -p codex-app-server was run; the config manager unit suite passed, but one unrelated integration test failed because turn_start_emits_thread_scoped_warning_notification_for_trimmed_skills expected 7 trimmed skills and observed 8.
• just fix -p codex-app-server

Changed files

• codex-rs/app-server/src/config_manager_service.rs (modified, +6/-8)
• codex-rs/app-server/src/config_manager_service_tests.rs (modified, +24/-0)