PR #17774: fix(tui): allow nullable session_id in /reload-mcp params

• Repository: NousResearch/hermes-agent
• Author: Heltman
• State: closed | merged: False
• Link: https://github.com/NousResearch/hermes-agent/pull/17774

Description (problem / solution / changelog)

Fixes #17773.

Problem

hermes --tui fails to build on current main because the /reload-mcp slash command declares its params with a non-nullable session_id: string, but ctx.sid is typed as string | null:

src/app/slash/commands/ops.ts(86,9): error TS2322: Type 'string | null' is not assignable to type 'string'.

First invocation on a fresh install dies during the auto-build step; dist/entry.js is never produced; TUI is effectively unusable.

Fix

Widen the param type to string | null to match ctx.sid and the convention used by every other slash command that forwards the session id (e.g. session.ts — prompt.background, config.set, session.compress, session.branch, image.attach all just spread session_id: ctx.sid without narrowing, and the gateway already handles null).

Smallest correct change; no runtime behavior difference.

Verification

cd ui-tui && npm run build   # now clean
hermes --tui -z "smoke test" # → responds normally

Regression introduced in

4d7fc0f37 — feat(gateway,cli): confirm /reload-mcp to warn about prompt cache invalidation. The TUI dev loop (tsx --watch) skips tsc -p tsconfig.build.json, so the build-time typecheck only fires when end users hit the launcher's on-demand build path. A CI job running npm run build on the TUI would catch future regressions of this class.

Changed files

• ui-tui/src/app/slash/commands/ops.ts (modified, +1/-1)

PR #17822: fix(tui): add null guard for ctx.sid in /reload-mcp slash command

• Repository: NousResearch/hermes-agent
• Author: luyao618
• State: closed | merged: False
• Link: https://github.com/NousResearch/hermes-agent/pull/17822

Description (problem / solution / changelog)

Summary

Add a null guard for ctx.sid in the /reload-mcp slash command handler, matching the existing pattern used by /rollback and /save.

Problem

When ctx.sid is null (no active session), /reload-mcp crashes because it passes null as session_id: string to the reload.mcp RPC call. The TypeScript type for params.session_id is string, but ctx.sid is string | null.

Fix

Added an early-return null check at the top of the run handler, before building the RPC params:

if (!ctx.sid) {
  return ctx.transcript.sys("/reload-mcp requires an active session")
}

This matches the guard pattern already used by /rollback (line 193) and /save in the same file.

Changed Files

• ui-tui/src/app/slash/commands/ops.ts — 3 lines added

Closes #17794

Changed files

• ui-tui/src/app/slash/commands/ops.ts (modified, +3/-0)

PR #17821: fix(tui): guard /reload-mcp against null ctx.sid

• Repository: NousResearch/hermes-agent
• Author: 0xDevNinja
• State: open | merged: False
• Link: https://github.com/NousResearch/hermes-agent/pull/17821

Description (problem / solution / changelog)

What does this PR do?

/reload-mcp declared params.session_id: string but read it directly from ctx.sid, which is typed as string | null. Triggering the command before a session was active crashed the TUI. Mirrors the null-guard pattern that /rollback (and /save) already use — surface a sys message instead of hitting the RPC with a null id.

Related Issue

Fixes #17794

Type of Change

• 🐛 Bug fix (non-breaking change that fixes an issue)

Changes Made

• ui-tui/src/app/slash/commands/ops.ts — early-return with ctx.transcript.sys('/reload-mcp requires an active session') when ctx.sid is null, before constructing params.
• ui-tui/src/__tests__/createSlashHandler.test.ts:
  • removed the table row that asserted reload.mcp is called with session_id: null (that was the bug — the typed string field was getting null).
  • added a positive test: active sid → RPC routed with the sid.
  • added a regression test: no sid → sys message, RPC not invoked.

How to Test

1. cd ui-tui && npm install
2. npm run build --prefix packages/hermes-ink
3. npx vitest run createSlashHandler — 45 / 45 pass, including the two new cases.
4. Full TUI suite (npx vitest run) — 539 / 539.
5. npm run type-check — clean.

Checklist

Code

• I've read the Contributing Guide
• My commit messages follow Conventional Commits
• I searched for existing PRs to make sure this isn't a duplicate
• My PR contains only changes related to this fix
• Targeted vitest run + full TUI suite + tsc --noEmit pass locally
• I've added tests for my changes
• I've tested on my platform: macOS 15 (Darwin 23.2)

Documentation & Housekeeping

• I've updated relevant documentation — N/A (no behavior change for users beyond the new sys message)
• I've updated cli-config.yaml.example — N/A
• I've updated CONTRIBUTING.md or AGENTS.md — N/A
• I've considered cross-platform impact — guard is platform-agnostic
• I've updated tool descriptions/schemas — N/A

Changed files

• ui-tui/src/__tests__/createSlashHandler.test.ts (modified, +20/-1)
• ui-tui/src/app/slash/commands/ops.ts (modified, +4/-0)