hermes - 💡(How to fix) Fix [Feature]: Align bg-review's bundled/pinned skill handling with the curator

Official PRs (…)
ON THIS PAGE

Recommended Tools

×6

Utilities matched from this issue’s tags and category — try them while you read without losing context.

GitHub issue graph ai analysis

Paste a GitHub issue URL. We fetch that issue, discover linked issues from bodies/comments/timeline, collect linked pull requests, and produce a structured English report.

The report is written in English Markdown for sharing and archival.

Helpful · Quick feedback

Loading…
RAW_BUFFERClick to expand / collapse

Problem or Use Case

Two writer systems govern the same skill files with inconsistent rules:

WriterFilters bundled?Filters pinned?
7-day curator✓ Yes (agent/curator.py:350: "DO NOT touch bundled or hub-installed skills")✓ Yes (curator.py:272, 350)
bg-review (per-session)✗ No✗ No

Same target files, two policies. Today this means bundled skills like hermes-agent are protected from the 7-day curator but get freely rewritten by bg-review on every qualifying session. Users discovering pin via hermes curator pin reasonably expect protection from automated edits — but bg-review ignores it.

Proposed Solution

Add a bundled/pinned filter to spawn_background_review_thread (agent/background_review.py) or at the call site in agent/conversation_loop.py:3981-3989. Default to the same allow/deny rules as curator.py. Add a config knob (skills.bg_review_includes_bundled: false) for users who want the old behavior.

Alternatives Considered

  • Document the asymmetry in user-guide/features/skills.md and update hermes curator pin --help to clarify that pin does not cover bg-review. Cheaper but leaves the surprising behavior in place.
  • Add bg-review-specific markers (per the companion issue on per-skill opt-out flags) — solves part of the problem but does not restore consistency between the two writer systems.

Feature Type: Configuration option Scope: Medium

Vote matrix · Quick signals

Works
Did the solution work? Tap to confirm.
Easy Fix
Was it a quick fix?
Time Saver
Did it save you time?
Blocking
Was it severely blocking?
Common Issue
Are others likely hitting this too?
Flaky / Intermittent
Is it intermittent?
Verified / Reproducible
Can you reproduce it reliably?
Loading…

Still need to ship something?

×6

Another batch ranked right after the header list — different links, same matching logic.

Back to top recommendations

TRENDING