hermes - 💡(How to fix) Fix fix(weixin): replace aiohttp ClientTimeout with asyncio.wait_for() [1 comments, 2 participants]

Timeout context manager should be used inside a task


Root Cause

_api_post and _api_get in gateway/platforms/weixin.py use aiohttp.ClientTimeout as a context manager passed directly to session.post/get():

python
timeout = aiohttp.ClientTimeout(total=timeout_ms / 1000)
async with session.post(url, data=body, headers=..., timeout=timeout) as response:


The timeout= argument to session.post() requires an active asyncio task context. When called via asyncio.run_coroutine_threadsafe() from cron jobs (which run in concurrent.futures.ThreadPoolExecutor), there is no asyncio task context — triggering the error.

Note that _upload_ciphertext (line ~579) and _download_bytes (line ~595) already use asyncio.wait_for() for this reason — the same fix was never applied to _api_post and _api_get.

Fix

Replace aiohttp.ClientTimeout with asyncio.wait_for() for both functions, matching the existing pattern:

python
async def _do_post() -> Dict[str, Any]:
    async with session.post(url, data=body, headers=_headers(token, body)) as response:
        raw = await response.text()
        if not response.ok:
            raise RuntimeError(f"iLink POST {endpoint} HTTP {response.status}: {raw[:200]}")
        return json.loads(raw)

Use asyncio.wait_for() instead of aiohttp ClientTimeout to avoid
"Timeout context manager should be used inside a task" errors when
invoked via asyncio.run_coroutine_threadsafe() from cron jobs.
return await asyncio.wait_for(_do_post(), timeout=timeout_ms / 1000)


Same pattern applied to _api_get.

Files Changed

- gateway/platforms/weixin.py: _api_post and _api_get — ~23 lines changed