hermes - 💡(How to fix) Fix hermes-achievements: memory_write_events counts all memory calls, not just writes [5 pull requests]

Bug

memory_write_events in plugins/hermes-achievements/dashboard/plugin_api.py counts all memory tool calls, not just write operations. This causes Memory Keeper and Memory Palace achievements to always show identical counts.

Root Cause

The metric is computed at line 357:

memory_write_events = _count_tool(tool_sequence, "mnemosyne_remember", "memory")

_count_tool uses substring matching (needle in name):

def _count_tool(tool_names, *needles):
    return sum(1 for name in lowered
               if any(needle in name for needle in needles))

The fallback needle "memory" matches every call to the built-in memory tool regardless of action (add, replace, list, search, remove). Since Hermes uses the memory tool name for all operations, memory_write_events degenerates into an exact copy of memory_events (line 356):

memory_events = _count_tool(tool_sequence, "memory", "mnemosyne")

Impact

• Memory Palace achievement always shows the same progress as Memory Keeper
• The "write-only" metric is meaningless — it cannot distinguish reads from writes at the tool-name level
• Users cannot see their actual durable-memory write count

Suggested Fix

Two options:

1. Parse tool arguments — inspect the action parameter of memory tool calls to count only add/replace actions. This is more correct but requires deeper session parsing (currently _count_tool only looks at tool names, not arguments).

2. Remove the "memory" fallback from memory_write_events — if mnemosyne_remember is the only write-specific tool name, drop the "memory" needle so it only matches mnemosyne_remember. This would undercount (miss memory tool writes) but at least not be a duplicate of memory_events.

Option 1 is the proper fix: inspecting tool call arguments to distinguish action=add/replace from action=list/search/remove.