hermes - 💡(How to fix) Fix hermes status reports sudo disabled when passwordless sudo works [2 comments, 2 participants]

import subprocess

sudo_password = os.getenv("SUDO_PASSWORD", "") passwordless_sudo = False

if not sudo_password: try: result = subprocess.run( ["sudo", "-n", "true"], stdout=subprocess.DEVNULL, stderr=subprocess.DEVNULL, timeout=2, ) passwordless_sudo = result.returncode == 0 except Exception: passwordless_sudo = False

sudo_enabled = bool(sudo_password) or passwordless_sudo

TL;DR

Update hermes_cli/status.py to detect passwordless sudo by checking the result of sudo -n true when SUDO_PASSWORD is not set.

Guidance

• The issue arises from hermes status only checking for the presence of SUDO_PASSWORD to determine sudo status.
• To fix this, modify the hermes_cli/status.py file to also check for passwordless sudo by running sudo -n true and checking its return code.
• If sudo -n true succeeds (return code 0), it indicates passwordless sudo is configured and working.
• Update the display logic to show whether sudo is enabled via SUDO_PASSWORD or passwordless sudo.

Example

import subprocess
import os

sudo_password = os.getenv("SUDO_PASSWORD", "")
passwordless_sudo = False

if not sudo_password:
    try:
        result = subprocess.run(
            ["sudo", "-n", "true"],
            stdout=subprocess.DEVNULL,
            stderr=subprocess.DEVNULL,
            timeout=2,
        )
        passwordless_sudo = result.returncode == 0
    except Exception:
        passwordless_sudo = False

sudo_enabled = bool(sudo_password) or passwordless_sudo
print(f"  Sudo:         {'✓ enabled (passwordless)' if passwordless_sudo else '✗ disabled'}")

Notes

This solution assumes that the sudo command is available and properly configured on the system. If sudo is not installed or not configured correctly, this solution may not work as expected.

Recommendation

Apply the proposed fix by updating hermes_cli/status.py to detect passwordless sudo, as this will correctly report the sudo status when passwordless sudo is configured.