PR #66649: fix(wizard): avoid setup crash on missing provider ids

• Repository: openclaw/openclaw
• Author: Tianworld
• State: closed | merged: True
• Link: https://github.com/openclaw/openclaw/pull/66649

Description (problem / solution / changelog)

## Summary

Prevent setup wizard crashes when provider plugin metadata is incomplete.

The setup flow compares provider ids using .trim(); if a provider entry is missing id, it crashed with TypeError: Cannot read properties of undefined (reading 'trim').

• Guard provider id comparisons when selecting the preferred provider for an auth choice.
• Add regression coverage.

Fixes #66641. Fixes #66619.

Test plan

• pnpm exec vitest run src/wizard/setup.test.ts

Changed files

• CHANGELOG.md (modified, +1/-0)
• src/wizard/setup.test.ts (modified, +56/-0)
• src/wizard/setup.ts (modified, +9/-3)

PR #66653: fix(telegram): add null safety to .trim() calls in setup flow

• Repository: openclaw/openclaw
• Author: mm1ord
• State: open | merged: False
• Link: https://github.com/openclaw/openclaw/pull/66653

Description (problem / solution / changelog)

Summary

Fixes #66619 — Telegram channel setup crashes with TypeError: Cannot read properties of undefined (reading 'trim') immediately after the DM policy warning banner.

What & Why

Multiple .trim() calls in the Telegram setup flow assume their operand is always a string. At runtime, these values can be undefined when the setup wizard encounters edge cases — e.g., a freshly initialized config with no token yet resolved, or a prompter returning undefined.

The previous refactoring in 96fe85fb ("refactor: dedupe telegram trimmed readers") replaced some .trim() calls with normalizeOptionalString() but missed several call sites that still called .trim() directly on potentially-undefined values.

Changes

Reproduction

1. Install openclaw v2026.4.14
2. Run through Telegram channel setup
3. Error is thrown after the DM policy warning banner

Workaround

Roll back to 2026.4.5: npm install -g [email protected]

AI-Assisted

• AI-assisted: Yes
• Degree of testing: Lightly tested (syntax validation passed; full pnpm build && pnpm check && pnpm test not available due to missing esbuild platform binary)
• Tool: Qoder AI coding assistant
• I understand what the code does: Yes — each change adds a null coalescing fallback (?? "") or explicit null guard before calling .trim(), ensuring the operation is safe even when the operand is undefined at runtime.

Changed files

• extensions/telegram/src/channel.ts (modified, +3/-3)
• extensions/telegram/src/doctor.ts (modified, +1/-1)
• extensions/telegram/src/setup-core.ts (modified, +3/-0)
• src/channels/plugins/setup-wizard-helpers.ts (modified, +4/-6)
• src/channels/plugins/setup-wizard.ts (modified, +1/-1)

PR #66882: fix(wizard): guard text-input prompts against undefined clack results

• Repository: openclaw/openclaw
• Author: nikilster
• State: open | merged: False
• Link: https://github.com/openclaw/openclaw/pull/66882

Description (problem / solution / changelog)

Summary

Fixes the widespread onboarding crash:

TypeError: Cannot read properties of undefined (reading 'trim')

that kills openclaw onboard / openclaw configure during channel selection and channel-specific text-input steps (Telegram, Slack, Discord, etc.).

Root cause

@clack/prompts text() can resolve to undefined in some edge cases (e.g. submitting an empty value when neither initialValue nor placeholder is set), even though WizardPrompter.text is declared as Promise<string>. The wrapper in src/wizard/clack-prompter.ts passes the value through guardCancel but does not coerce the non-cancel path, so undefined leaks out to callers. buildChannelSetupWizardAdapterFromSetupWizard in src/channels/plugins/setup-wizard.ts then calls rawValue.trim() directly and crashes.

Fix

• src/wizard/clack-prompter.ts — enforce the declared Promise<string> contract by coercing nullish results to "" after guardCancel. This covers every prompter.text caller in one place.
• src/channels/plugins/setup-wizard.ts — belt-and-suspenders rawValue ?? "" at the existing call site so the same symptom can't be reintroduced by a future prompter swap.
• src/wizard/clack-prompter.test.ts — unit tests for the wrapper covering both the undefined → "" coercion and the string passthrough.

Related issues

• #66693 [Bug]: While onboarding: TypeError: Cannot read properties of undefined (reading 'trim')
• #66718 [Bug] openclaw configure TypeError: Cannot read properties of undefined (reading 'trim')
• #66848 [Bug]: TypeError: Cannot read properties of undefined (reading 'trim')
• #66677 [Bug]: Select channel (QuickStart)
• #66624 (closed) same symptom, v2026.4.14
• #66728 (closed) Skip for now variant
• #66641 (closed) installer crashes after Select channel (QuickStart)
• #66619 (closed) Telegram setup variant

Test plan

• New unit tests in src/wizard/clack-prompter.test.ts pass locally against the patched wrapper.
• CI: pnpm test:unit / channel plugin tests.
• Manual: openclaw onboard, pick Telegram, step through the text-input steps without hitting the TypeError.

Changed files

• src/channels/plugins/setup-wizard-helpers.ts (modified, +7/-7)
• src/channels/plugins/setup-wizard.ts (modified, +1/-1)
• src/wizard/clack-prompter.test.ts (modified, +40/-2)
• src/wizard/clack-prompter.ts (modified, +7/-1)